Position MCP as coming soon for public CLI launch#1
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
MCP is not launched for the public CLI yet, and there are no existing public MCP users to preserve compatibility for. The product goal is not to hide code or describe a broken feature as "disabled". Instead, the CLI should be honest that MCP is coming soon while making direct CLI commands the only supported launch surface today.
Before this PR, top-level help/docs/setup flows described MCP as usable: users could discover
sume mcp, install local client config, inspect MCP client readiness, and see MCP payload schemas throughsume tools. That made MCP look launched and reliable even though it is not ready for public users.Implementation
src/lib/mcp-launch-status.tsobject: "mcp_status",status: "coming_soon",launched: false, andrecommended_surface: "direct_cli".src/commands/mcp.tssume mcpfrom top-level help but leaves explicit command access for clear status/error handling.sume mcpreturnsmcp_not_launchedinstead of starting the stdio server.sume mcp installreturnsmcp_not_launchedand does not write client config, even in dry-run mode.sume mcp doctorreturns the launch status only, without reading or validating local MCP client config as a launched feature.src/commands/setup.tssume setupfrom top-level help.sume setup agentreturnsagent_setup_not_launchedand does not install MCP/agent config.src/index.tsandsrc/commands/doctor.tsmcpandsetupfrom root JSON command discovery.coming_soonmetadata tosume --json.doctoroutput to report MCP as coming soon rather than checking launched MCP client readiness.src/lib/tool-registry.tsandsrc/commands/tools.tssume toolsas CLI command schema discovery.mcp_input_schema: nullandexecution.mcp_tool: null.mcp: { status: "coming_soon", launched: false }metadata so agents do not treat MCP payloads as usable.jobs.waitandassets.upload_filefrom publicsume tools list/schemadiscovery.src/mcp/tools.ts.github/workflows/ci.ymland.github/workflows/release.ymlcoming_soonmetadata.README.md,docs/*,agent/*, andsrc/lib/bundled-skills-data.tsagent/files.package.jsonPublic Contract / Schema Notes
sume --helpno longer advertisesmcporsetupas launched top-level commands.sume --jsonno longer listsmcporsetupundercommands; it includes acoming_soonMCP status entry instead.sume mcp,sume mcp install, andsume setup agentcalls fail clearly with coming-soon JSON errors in--jsonmode.sume mcp doctor --jsonremains a status-only command and returnsstatus: "coming_soon"/launched: false.sume tools list/schemaremains supported for CLI schema discovery but does not expose usable MCP input schemas or MCP-only helper tools as public launch contracts.Verification
pnpm run typecheck- passed.pnpm exec vitest run test/cli.test.ts test/mcp.test.ts- passed after the final test wording amend: 84 tests passed.pnpm run check- passed before the final test-title-only/workflow-smoke commits: version check, typecheck, full test suite, node build, and secrets check all passed; 119 tests passed; no obvious secrets found.pnpm run build:binaryplus local CI-equivalent binary smoke - passed after updating the workflow smoke:./dist/sume --version./dist/sume --json tools schema jobs.watch./dist/sume --json tools schema assets.create./dist/sume --json tools schema assets.get./dist/sume --json tools schema avatars.create./dist/sume --json tools schema avatar-videos.create./dist/sume --json skills list./dist/sume --jsonwith"coming_soon"and"mcp_status"checksnode dist/index.js --helpomittedmcpandsetupfrom top-level help.node dist/index.js --jsonomittedmcpandsetupfromcommandsand includedcoming_soonMCP status.node dist/index.js --json mcp doctorreturnedobject: "mcp_status",status: "coming_soon",launched: false.node dist/index.js --json mcp install --agent codex --dry-runexited nonzero withmcp_not_launchedand did not enter config writing.Review Notes
jobs.wait/assets.upload_fileexpectations.Risk / Rollback
Follow-ups